Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the plugin with last frameworks and features #1021

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

vash15
Copy link
Contributor

@vash15 vash15 commented Mar 8, 2019

Hello everyone, I tried to update the plugin by integrating some pull requests already launched but not accepted. In particular, I wanted to review the installation of the plugin and unpack the framework's dependencies from the plugin, so you can manage the updates of the frameworks, independently without having to wait for a new plugin update.

This pull request contains production level code already delivered in production environment.

  • New features of Firebase Crashlitycs
  • The Firebase Performance update
  • Firebase Dynamic Links
  • Update of Firebase Analytics which includes nesting of bundle data (Android).
  • Installation of Firebase libraries via Cocoapods (iOS). This decision is the responsibility of the developer. See the documentation: Get started.
  • New structured documentation as the official Google Firebase documentation

I hope to help many with this pull request. I ask for your support and help me to get approved, improved and tested.

Thank you

Migrate incrementCounter to incrementMetric
Add a support of Universal links, deeplinks and Firebase Dynamic Links
# Conflicts:
#	README.md
#	package.json
#	plugin.xml
#	src/android/FirebasePlugin.java
#	src/android/build.gradle
#	www/firebase.js

Upgrade Firebase SDK 5.11.0
…re decided by the developer and not by the plugin. This is to improve the update of dependency libraries. In addition, some unpicked pull requests were included, due to the need for development. Improved Firebase Crashlitycs, adding non-fatal carsh tracking. Rewrite the documentation based on the official Firebase documentation.
@nicksteenstra
Copy link

Hey @vash15!

Thanks for the update! Any way I can grab this code and run/test it in a new app I'm working on?

@nicksteenstra
Copy link

@robertarnesson @briantq What can be done to get this PR approved? Very interested in using the dynamic links together with messaging and this library seems like the best suited for it. Let me know if I can help in any way!

@vash15
Copy link
Contributor Author

vash15 commented Mar 19, 2019

Hi @nicksteenstra , to try my PR run this command:
cordova plugin add https://github.com/vash15/cordova-plugin-firebase#master
or download the plugin from my fork and install it from the local folder
cordova plugin add ../plugin_folder.

Thanks a lot!

@nicksteenstra
Copy link

Awesome, thank you! I hope to get this into our code and test it soon! Keep you posted here on how the testing goes.

@ryanmtaylor
Copy link

got this issue: Failed to install 'cordova-plugin-firebase': Error: Cannot find module 'xml2js'

vash15 added 2 commits May 28, 2019 10:50
Copy link

@yoga1290 yoga1290 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution works for me when Play Service version + fails

@Sagarkhenat
Copy link

Hello @vash15 I tried to use your fork for my ionic cordova app by adding the plugin as ionic cordova plugin add https://github.com/vash15/cordova-plugin-firebase#master. Then ran the cordova prepare command.But while building the build fails and it says could not find #import <Firebase.h>. Did i miss any steps while installing the plugin?

@ryanmtaylor
Copy link

@Sagarkhenat this whole repo is being deprecated in favor of https://github.com/dpa99c/cordova-plugin-firebasex – try that instead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants