-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to make setScreenName run in main thread. #751
Conversation
Just curious, what is it that's not working on iOS? Screen name is apparently working for me - it appears in the Analytics dashboard, at least. |
Whats the status here? Will this be merged? @soumak77 |
@sandfield-andy could you fix the merge conflicts so I can merge this PR? |
fixed via bce8acd |
@soumak77 will you be doing a new release version with this fix? 1.1.1? |
@JonSmart sure, publishing now |
@soumak77 perfect. Thanks. |
Has this been pushed in? |
@newuser44 yes, try version 1.1.4 |
it seems to be pulling firebase 2.0.0 I know there is a way to pull a specific version. |
2.0 should be fine too. 2.0 upgrades firebase SDK which you might want as well. See the CHANGELOG for more info. If you want 1.1.4, run |
it looks like I have 1.1.4 |
@newuser44 I believe #832 will fix your problem. If you are able to test that PR, we can get a new version published sooner |
Sorry, not really sure how I would test that seperate build. Are these problems solved in the 2.0 version? |
@newuser44 the setScreenName running on the main thread is fixed, but we need #832 merged to fix the issue you're running into with analytics not being initialized |
I've made changes to the
setScreenName
function to run in the main thread. This is needed to make it work for iOS.