Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Enable compilerOptions.experimentalDecorators for compatibility with Deno 1.41 #60

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

catuhana
Copy link
Collaborator

@catuhana catuhana commented Feb 23, 2024

Deno 1.41 have an entirely different Decorator API, and libraries we use (mainly Harmony) is not ported to it. To get benefits of smaller deno compile and native ARM64 Linux outputs, we allow old Decorator API for now.

…h Deno 1.41

Deno 1.41 have an entirely different Decorator API, and libraries we use (mainly Harmony) is not ported to it.
To get benefits of smaller `deno compile` and ARM64 Linux outputs, we allow old Decorator API for now.
@catuhana catuhana requested a review from aronson February 23, 2024 10:11
@catuhana
Copy link
Collaborator Author

To add a note: aarch64-unknown-linux-gnu target is still not added to deno compile --target flag.

@catuhana
Copy link
Collaborator Author

catuhana commented Feb 23, 2024

I cloned Deno locally and added aarch64 Linux target to see if it was uncomplete or just aren't added to compile flags, and it seems the latter. We just need to wait for Deno to add those targets. After that we can drop pi runner.

Also there seems to be a bug with compile, it won't save the output file with os error 13. I'm hoping those will be fixed with Deno 1.41.1. Doesn't happen with CI or Docker, might be related to my system.

@catuhana
Copy link
Collaborator Author

Apparently, denoland/deno#22542 exists.

@aronson aronson requested a review from MTF February 23, 2024 14:10
@aronson aronson merged commit d9e9c35 into aronson:main Feb 26, 2024
1 check passed
@catuhana catuhana deleted the deno-v1.41 branch March 1, 2024 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants