ARQ-2071 Use more safe serverifo command to check if container runs #37
Conversation
| public void serverInfo() throws IOException { | ||
| execute(tomcatManagerCommandSpec.getServerInfoCommand(), null, null, -1); | ||
| } | ||
|
|
||
| public void list() throws IOException { |
There was a problem hiding this comment.
It seems that by introducing serverInfo list method became obsolete. Can you clean up unused code?
There was a problem hiding this comment.
I think it's same also for the methods getListCommand() in Tomcat**ManagerCommandSpec classes
|
As discussed with @MatousJobanek, to keep backward compatibility, |
|
Is it something which is public facing? I thought it's more an internal implementation of how we handle the containers (in this case Tomcat). If that is the case, then obviously |
|
The method is |
|
I totally understand your concern and appreciate raising it. I'm not aware of any usage of it. I thought maybe @MatousJobanek knows something :) |
|
Neither do I TBH :-D. I thought that @vjuranek uses this code somewhere in his test suite (as an API method). On the other hand, we have a CR release and according to "standard process" I think that we shouldn't remove (radically change) anything that is publicly available (public methods mainly in interfaces). Personally, I would keep it with the annotation |
|
+1, squashed and merged! Thank you @vjuranek |
|
great, thanks! |
Short description of what this resolves:
Use more safe
serverifocommand to check if container runsChanges proposed in this pull request:
listtoserverinfoas not all session managers implementslistcommand (typically for security reasons)Fixes: https://issues.jboss.org/browse/ARQ-2071