Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parallel): uses InheritableThreadLocal for TestNG test runner #205

Merged
merged 4 commits into from
Sep 26, 2019
Merged

fix(parallel): uses InheritableThreadLocal for TestNG test runner #205

merged 4 commits into from
Sep 26, 2019

Conversation

SarahFaller213
Copy link
Contributor

Description: Enabling Parallel Execution

Fix: using InheritableThreadLocal instead of threadlocal.

@bartoszmajsak
Copy link
Member

bartoszmajsak commented Jul 30, 2019 •
edited
Loading

Thank you very much @SarahFaller213 for this fix. Do you have some sample project with Drone (as I guess that was your target use case) so that I can give it a spin and see in action?

Or did you try https://github.com/vinsguru/arquillian-testng-parallel provided in arquillian/arquillian-extension-drone#87 as a testing ground?

@bartoszmajsak bartoszmajsak self-requested a review July 30, 2019 04:50
@SarahFaller213
Copy link
Contributor Author

Thank you very much @SarahFaller213 for this fix. Do you have some sample project with Drone (as I guess that was your target use case) so that I can give it a spin and see in action?

Or did you try https://github.com/vinsguru/arquillian-testng-parallel provided in arquillian/arquillian-extension-drone#87 as a testing ground?

@SarahFaller213 SarahFaller213 reopened this Aug 1, 2019
@SarahFaller213
Copy link
Contributor Author

@bartoszmajsak
https://github.com/SarahFaller213/dummyService
here is a dummyService to run the test! Please let me know if there is anything else you need.

@bartoszmajsak bartoszmajsak changed the title parallel execution fix fix(parallel): uses InheritableThreadLocal for TestNG test runner Sep 26, 2019
@bartoszmajsak bartoszmajsak merged commit 8f74705 into arquillian:master Sep 26, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoszmajsak bartoszmajsak bartoszmajsak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SarahFaller213 @bartoszmajsak