chore: cleans up junit5 module #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why that file is needed on container side?
ingwarsw
commented
Dec 10, 2020
...t5/core/src/main/java/org/jboss/arquillian/junit5/JUnitJupiterTestClassLifecycleManager.java
Outdated
Show resolved
Hide resolved
Also fixes issue with using global store for results
|
@bartoszmajsak And would be cool to actually write any tests for junit5 module.. |
|
Thanks for your work. Much appreciated. I will go over the code and run some tests this weekend and come back with more feedback.
Don't have any excuse besides wanting to get some feedback from the Alpha release based on the code which was already there as an external extension. I will however work on the tests during Xmas break, as we have to have them sooner than later. |
lprimak
approved these changes
Jan 29, 2021
|
Looks great |
bartoszmajsak
changed the title
bartoszmajsak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Cleaning of junit5 arquillian module..
Because jupiter have state keeping it in extra threads is not needed.
Changes proposed in this pull request:
Im not sure if cleaning didnt went way too far..
Please look..
I will test it thoroughly now to see how many things I broke..