Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing inner string tuples is broken #162

Open
marcelocantos opened this issue Apr 26, 2020 · 0 comments
Open

Removing inner string tuples is broken #162

marcelocantos opened this issue Apr 26, 2020 · 0 comments
Labels
P1 Medium priority issue

Comments

@marcelocantos
Copy link
Contributor

marcelocantos commented Apr 26, 2020 •
edited
Loading

Please do not post any internal, closed source snippets on this public issue tracker!

Description

Strings are logically sets of tuples. Removing from the start and the end works fine, but excluding tuples from the middle replaces them with null values: (@: ..., @char: 0) instead of removing them outright.

Steps to Reproduce

  1. @> "gap" where .@ != 1

Expected behavior:

{(@: 0, @char: 103), (@: 2, @char: 112)}

Actual behavior:

'g\x00p'
@marcelocantos marcelocantos added the P1 Medium priority issue label Apr 26, 2020
anzopensource pushed a commit that referenced this issue Apr 27, 2021
@nofun97
simplify Set.ArrayEnumerator signature (#162)
f29e6e9 
* simplify Set.ArrayEnumerator signature

ArrayEnumerator returns an OffsetValueEnumerator and a bool which were
unnecessary. Now it just returns a ValueEnumerator and returns a nil
if it doesn't have an ArrayEnumerator (dictionary). This commit also includes
some changes to BytesTuple because there was unnecessary code.

* return empty enumerator

* fix genericSet.ArrayEnumerator

* panic on emptyEnumerator.Current
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcelocantos