Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move arraiParsers to a separated file #179

Merged
merged 1 commit into from
May 1, 2020
Merged

move arraiParsers to a separated file #179

merged 1 commit into from
May 1, 2020

Conversation

ChloePlanet
Copy link
Contributor

@ChloePlanet ChloePlanet commented May 1, 2020 •
edited
Loading

Changes proposed in this pull request:

  • move arraiParsers in syntax/parse.go to a separated file syntax/arrai.wbnf
  • generate syntax/parser.go via syntax/arrai.wbnf

@ChloePlanet ChloePlanet force-pushed the chloe/generate-parser branch from 6057f1c to 12b706e Compare May 1, 2020 03:56
@ChloePlanet ChloePlanet force-pushed the chloe/generate-parser branch from 12b706e to 8246a91 Compare May 1, 2020 04:08
@ChloePlanet ChloePlanet marked this pull request as ready for review May 1, 2020 04:11
@github-actions
Copy link

github-actions bot commented May 1, 2020

Pull Request Test Coverage Report for Build 905d4debb6960a9dec9090f1fe96528bf8c62443-PR-179

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 41.251%
Totals Coverage Status
Change from base Build 67d614d9edaa57b60bf99876e290903ad7f6bb5b: 0.04%
Covered Lines: 2829
Relevant Lines: 6858
💛 - Coveralls

@ChloePlanet ChloePlanet requested a review from marcelocantos May 1, 2020 04:12
anzdaddy
anzdaddy approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@anzdaddy anzdaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ChloePlanet ChloePlanet merged commit 7806475 into master May 1, 2020
@ChloePlanet ChloePlanet deleted the chloe/generate-parser branch May 1, 2020 04:27
anzopensource pushed a commit that referenced this pull request May 13, 2021
@nofun97 @anzdaddy
implement true as its own type TrueSet (#179)
7c63948 
Co-authored-by: Marcelo Cantos <anzdaddy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anzdaddy anzdaddy anzdaddy approved these changes

@marcelocantos marcelocantos Awaiting requested review from marcelocantos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChloePlanet @anzdaddy