Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle duplicated tuple pattern name #256

Merged
merged 1 commit into from
May 14, 2020
Merged

handle duplicated tuple pattern name #256

merged 1 commit into from
May 14, 2020

Conversation

ChloePlanet
Copy link
Contributor

Changes proposed in this pull request:

  • handle duplicated tuple pattern name
  • two sides of tuples in let statement must be the same name:expr

@ChloePlanet ChloePlanet requested a review from marcelocantos May 14, 2020 02:19
@coveralls
Copy link

Pull Request Test Coverage Report for Build d1469eab18f0ffede67db59f2b9ffb0dec5d397b-PR-256

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 41.872%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rel/pattern.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
syntax/import_cache.go 1 80.49%
rel/value_set_array.go 2 27.44%
Totals Coverage Status
Change from base Build 279544ed65ff7b49b2d56d727a6fb1f611dc44ae: -0.01%
Covered Lines: 3086
Relevant Lines: 7370
💛 - Coveralls

@ChloePlanet ChloePlanet merged commit 452302e into master May 14, 2020
@ChloePlanet ChloePlanet deleted the chloe/dup-tuple-name branch May 14, 2020 04:09
@ChloePlanet ChloePlanet mentioned this pull request May 20, 2020
Closed
@marcelocantos marcelocantos mentioned this pull request May 21, 2020
Closed
13 tasks
anzopensource pushed a commit that referenced this pull request Apr 14, 2022
@nofun97
bump github-tag-action version to 1.36.0 (#256)
bdfa82c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anzdaddy anzdaddy anzdaddy approved these changes

@marcelocantos marcelocantos Awaiting requested review from marcelocantos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChloePlanet @coveralls @anzdaddy