Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand unop and binop source to include args #259

Merged
merged 1 commit into from
May 14, 2020
Merged

Expand unop and binop source to include args #259

merged 1 commit into from
May 14, 2020

Conversation

marcelocantos
Copy link
Contributor

@marcelocantos marcelocantos commented May 14, 2020 •
edited
Loading

Worst case, falls back to the current behaviour of highlighting just the operator if merging Scanners fails.

Checklist:

  • [n/a] Added related tests
  • [n/a] Made corresponding changes to the documentation

@coveralls
Copy link

Pull Request Test Coverage Report for Build 98f280d56331233eda6956134984145c2fb0f722-PR-259

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 41.97%
Files with Coverage Reduction New Missed Lines %
rel/value_set_array.go 2 27.44%
Totals Coverage Status
Change from base Build 452302eb5f1d55197a2f7982f03d39ac78989625: 0.2%
Covered Lines: 3097
Relevant Lines: 7379
💛 - Coveralls

@marcelocantos marcelocantos merged commit a2ebd62 into master May 14, 2020
@marcelocantos marcelocantos deleted the expand-expr-source branch May 14, 2020 08:37
anzopensource pushed a commit that referenced this pull request May 23, 2022
@nofun97
fix bug where union of the same relations create a union set (#259)
fb391b2 
This bug was caused due to relation.unionSetSubsetBucket not returning a sorted column names which cause relations with the same column names but different order be treated as different type of relations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelocantos @coveralls