Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 97: Support for Alternative Representations #106

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Issue 97: Support for Alternative Representations #106

merged 5 commits into from
Oct 17, 2024

Conversation

arran4
Copy link
Owner

@arran4 arran4 commented Oct 15, 2024 •
edited
Loading

See my comment: #97

For details

Waiting review of original posters.

Also #73 is impacted sorry @ManoloTonto1 I will have to update my pr

Error additions and better matching of spec: https://icalendar.org/iCalendar-RFC-5545/3-2-1-alternate-text-representation.html

@arran4 arran4 mentioned this pull request Oct 15, 2024
Closed
@arran4 arran4 mentioned this pull request Oct 15, 2024
Open
@arran4 arran4 assigned arran4 and unassigned arran4 Oct 15, 2024
@masterElmar
Copy link

First Tests with Thunderbird as altrep in text/html works. Ill test some of the other altreps like chrome and plain.
But many changes and a lot of good refactoring and renaming ✅ 😊

@arran4
Copy link
Owner Author

arran4 commented Oct 15, 2024

image

Looks like I have some conflicts to resolve tomorrow too

@arran4 arran4 changed the title Issue 97 Issue 97: Support for Alternative Representations Oct 15, 2024
@arran4
Merge remote-tracking branch 'origin/master' into issue97
1015df8 
* origin/master:
  Duplication issue fixed.
  Some multiple-ness.
  Test fixed.
  Resynced and moved some functions around #78
  added functionnal option pattern for url parsing
  usage example, README
  calendar parsing url support
@arran4
Merge remote-tracking branch 'origin/master' into issue97
0d0e9ff 
* origin/master:
  Duplication issue fixed.
  Some multiple-ness.
  Test fixed.
  Resynced and moved some functions around #78
  added functionnal option pattern for url parsing
  usage example, README
  calendar parsing url support

# Conflicts:
#	calendar.go
#	calendar_test.go
#	components.go
@arran4
Copy link
Owner Author

arran4 commented Oct 16, 2024 •
edited
Loading

That was a painful conflict resolution for such a small difference. Let me know how further testing goes please.

How long should I wait for?

@masterElmar
Copy link

That was a painful conflict resolution for such a small difference. Let me know how further testing goes please.

How long should I wait for?

Thank you for all the effort 👍
Ill would test it the next 24h and then you could go on.
As far as i tested my Google and Thunderbird cases everything passes and after import of ical looks right.

@arran4
Copy link
Owner Author

arran4 commented Oct 16, 2024

Awesome. Thanks. I will look for a Saturday (Australian Eastern Standard time) merge.

@arran4
Copy link
Owner Author

arran4 commented Oct 16, 2024

Are you happy to wait for the other PRs, or do you want a semantic release for these changes this weekend? (The other PRs could take until the end of the year.)

@arran4 arran4 linked an issue Oct 16, 2024 that may be closed by this pull request
optional/generic serializing #97
Closed
@masterElmar
Copy link

Are you happy to wait for the other PRs, or do you want a semantic release for these changes this weekend? (The other PRs could take until the end of the year.)

A release in the near future would be nice, because we use this library in our open source project for student schedules.
The new feature with altreps for diffrent clients is very helpful in our case.

@arran4
Copy link
Owner Author

arran4 commented Oct 16, 2024

Okay once tested, then a final test once released.

masterElmar
masterElmar approved these changes Oct 16, 2024
View reviewed changes
calendar.go Show resolved Hide resolved
components.go Show resolved Hide resolved
@arran4 arran4 merged commit 4b57639 into master Oct 17, 2024
23 checks passed
@arran4 arran4 deleted the issue97 branch October 17, 2024 01:13
@arran4
Copy link
Owner Author

arran4 commented Oct 17, 2024

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterElmar masterElmar masterElmar approved these changes

Assignees

@arran4 arran4

Labels
pending-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optional/generic serializing
2 participants
@arran4 @masterElmar