Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"IsDuring" function #110

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

"IsDuring" function #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a55b8bf
Parse time. Pending merge with https://github.com/arran4/golang-ical/…
arran4 Oct 15, 2024
48241ea
Merge remote-tracking branch 'origin/master' into IsDuring
arran4 Oct 16, 2024
44a5613
Merge branch 'master' into IsDuring
arran4 Oct 17, 2024
d072797
Property util funcs
arran4 Oct 28, 2024
8abce98
It all works except one section.
arran4 Oct 28, 2024
564e7cb
Skip the test when we know it's going to fail.
arran4 Oct 28, 2024
7151e71
Commented out exception as it isn't a valid exception.
arran4 Oct 28, 2024
14d7e7c
Empty timezone is UTC assumed for compatibility reasons with 'TestSet…
arran4 Oct 28, 2024
d1cd0d1
Lint
arran4 Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion calendar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,8 @@ func (cal *Calendar) SetDescription(s string, params ...PropertyParameter) {
}

func (cal *Calendar) SetLastModified(t time.Time, params ...PropertyParameter) {
cal.setProperty(PropertyLastModified, t.UTC().Format(icalTimestampFormatUtc), params...)
layout, params := timestampFormatForTime(t, params)
cal.setProperty(PropertyLastModified, t.Format(layout), params...)
}

func (cal *Calendar) SetRefreshInterval(s string, params ...PropertyParameter) {
Expand Down
12 changes: 6 additions & 6 deletions calendar_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func TestTimeParsing(t *testing.T) {
},
}

assertTime := func(evtUid string, exp time.Time, timeFunc func() (given time.Time, err error)) {
assertTime := func(t *testing.T, evtUid string, exp time.Time, timeFunc func() (given time.Time, err error)) {
given, err := timeFunc()
if err == nil {
if !exp.Equal(given) {
Expand All @@ -104,17 +104,17 @@ func TestTimeParsing(t *testing.T) {
}

for _, tt := range tests {
t.Run(tt.uid, func(t *testing.T) {
t.Run(tt.name, func(t *testing.T) {
evt, ok := eventMap[tt.uid]
if !ok {
t.Errorf("Test %#v, event UID not found, %s", tt.name, tt.uid)
return
}

assertTime(tt.uid, tt.start, evt.GetStartAt)
assertTime(tt.uid, tt.end, evt.GetEndAt)
assertTime(tt.uid, tt.allDayStart, evt.GetAllDayStartAt)
assertTime(tt.uid, tt.allDayEnd, evt.GetAllDayEndAt)
assertTime(t, tt.uid, tt.start, evt.GetStartAt)
assertTime(t, tt.uid, tt.end, evt.GetEndAt)
assertTime(t, tt.uid, tt.allDayStart, evt.GetAllDayStartAt)
assertTime(t, tt.uid, tt.allDayEnd, evt.GetAllDayEndAt)
})
}
}
Expand Down
Loading
Loading