-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add other Components creation and properties methods (#65) #66
Conversation
I've already notice a typo in components.go where the VTodo |
Workflow failed seems to be caused by an incident at Github, issue is resolved now, so we should be able to just rerun it. |
Okay attempting to re-run them all |
@spslater It still seems to be failing. However for much clearer reasons:
|
Whoops, not sure how I missed that, fixed it and a couple other things I caught. |
@spslater There is a conflict. |
@spslater I have attempted to resolve the conflict. Please take a look at some stage. |
Bah I broke it. |
Okay.. Github merge helped me mangle that. |
8fe8d60
to
8525f6b
Compare
Force pushed removal. Shouldn't have closed it though. |
Looks like that force push overwrote some of the changes, I will see if I can get a clean merge with some small changes from my local copy. |
Bah trashed more commits than I should have. I had to restart the merge please look at #84 |
I think I salvaged it. Perhaps compare? |
Changes for issue #65:
VEvent
toComponentBase
so that the Todo and Journal objects would also have access to them, without needing to duplicate the methodssetPriority
andsetResources
I made them private on the ComponentBase and then added public methods on the Components they're valid in, Event and Todo. I'm not super married to this idea, there is probably a better way to handle this without duplicating too much code.serialize
,Serialize
)AddEvent
,AddVEvent
)Events
)SetEndAt
)SetPriority
)GetEndAt
)