Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Fix python module build method #1072

Merged
merged 10 commits into from
Jan 13, 2022
Merged

Fix python module build method #1072

merged 10 commits into from
Jan 13, 2022

Conversation

dchassin
Copy link
Member

@dchassin dchassin commented Jan 9, 2022

This PR fixes issue #986.

Current issues

  1. The wheel name does not conform to PEP 440 standard.
  2. This PR to the build method doesn't make the deprecation error go away. However, it does bring the build method up to PEP 440 standards, which is important.

Code changes

  • Fix gldcore/link/python/{Makefile.mk,setup.py} to use python build module instead of disttools.

Documentation changes

None

Test and Validation Notes

You may notice warning errors about the version name not conforming to the PEP 440 standard. This is not a problem. Yet.

@dchassin dchassin linked an issue Jan 9, 2022 that may be closed by this pull request
@dchassin dchassin mentioned this pull request Jan 10, 2022
23 tasks
@aivanova5 aivanova5 self-requested a review January 13, 2022 06:13
Copy link
Collaborator

@aivanova5 aivanova5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makefile.mk contains line @python3 -m pip uninstall gridlabd -y which breaks make reconfigure on Darwin

Found existing installation: gridlabd 4.2.30.220112
ERROR: Cannot uninstall 'gridlabd'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.

@dchassin
Copy link
Member Author

dchassin commented Jan 13, 2022

Makefile.mk contains line @python3 -m pip uninstall gridlabd -y which breaks make reconfigure on Darwin

Found existing installation: gridlabd 4.2.30.220112
ERROR: Cannot uninstall 'gridlabd'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.

This error will only occur if you use make reconfigure or make clean on an build made with the older python build method. Use . utilities/cleanwc followed by autoreconf -isf && ./configure instead to avoid this transient problem. A message to that effect has been added to the makefile when that error occurs.

@dchassin dchassin requested a review from aivanova5 January 13, 2022 20:20
@aivanova5 aivanova5 merged commit a16e9bf into develop Jan 13, 2022
@aivanova5 aivanova5 deleted the develop-fix-python-build branch January 13, 2022 22:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade needed to python module build
2 participants