Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Update node.cpp #1184

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Update node.cpp #1184

merged 1 commit into from
Jun 14, 2022

Conversation

dchassin
Copy link
Member

This PR delays the initialization of node voltage_violation_threshold so it accounts for changes in the module default if the change is made after the node is created.

@dchassin dchassin added the bug Request a fix or change to the code label Jun 14, 2022
@dchassin dchassin added this to the GLOW Final Release milestone Jun 14, 2022
@dchassin dchassin self-assigned this Jun 14, 2022
@dchassin dchassin requested a review from johnsonhsiung June 14, 2022 21:48
@johnsonhsiung johnsonhsiung merged commit b4b91e0 into develop Jun 14, 2022
@johnsonhsiung johnsonhsiung deleted the develop-fix-node-violation-default branch June 14, 2022 22:27
@dchassin dchassin restored the develop-fix-node-violation-default branch June 14, 2022 23:36
@dchassin dchassin deleted the develop-fix-node-violation-default branch April 15, 2023 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Request a fix or change to the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants