Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xy coordinate data extract from cyme converter #111

Merged
merged 34 commits into from
Oct 12, 2023
Merged

Fix xy coordinate data extract from cyme converter #111

merged 34 commits into from
Oct 12, 2023

Conversation

MitchellAV
Copy link
Contributor

This commit fixes #46

MitchellAV and others added 26 commits October 4, 2023 04:16
@MitchellAV
Modified xy coordinate extract to include all node types
3c69de9 
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Added autotest for xy coordinates extract
2ada420 
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Fixed autotest for other cyme converter tests
3f88fde 
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Removed debug code from development
57d9506 
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Create version 4.3.3
0a81ed2 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Fix product name (arras-energy#7)
259efee 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Fix ISONE help data (arras-energy#12)
271b13a 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Update install tool (arras-energy#14)
90dbe90 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Fix make install (arras-energy#15)
9043eb6 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Fix install tool (arras-energy#16)
bd1796e 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Refactor pole (arras-energy#8)
fc6e6e4 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Fix superlu compile warnings (arras-energy#17)
bf582dd 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Update documentation (arras-energy#18)
95d751e 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Update ubuntu_22.sh (arras-energy#90)
8ca565a 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Update load.cpp to fix mdb converter (arras-energy#91)
531eaf9 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Add pole failure warning (arras-energy#93)
2121642 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Fix global substitution (arras-energy#94)
7b92b90 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Develop fix macro python (arras-energy#95)
052934d 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Fix forloop comments (arras-energy#96)
82131b2 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Update repo docs (arras-energy#97)
05f2806 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Fix recorder output (arras-energy#99)
c6e90ab 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Fix geodata tutorial (arras-energy#101)
9e2d3a4 
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Update gridlabd.in
17f6d78 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Fix include subcommand (arras-energy#104)
fbe3cc4 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Fix fast accessor autotest (arras-energy#98)
8f1f921 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV
Fix server autotest intermittent failure (arras-energy#106)
50e3a30 
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@MitchellAV MitchellAV force-pushed the develop-cyme-extract-xy-data branch from 7ab4281 to 50e3a30 Compare October 4, 2023 04:17
@dchassin dchassin mentioned this pull request Oct 6, 2023
Merged
55 tasks
@dchassin dchassin added the enhancement New feature or request label Oct 6, 2023
@dchassin
Copy link
Member

@MitchellAV, note the failures of the mdb2glm converters. See validation results.

@dchassin dchassin changed the title Fixes xy coordinate data extract from cyme converter Fix xy coordinate data extract from cyme converter Oct 10, 2023
@MitchellAV
Copy link
Contributor Author

@dchassin I'll take a look. I think I know what happened

David P. Chassin and others added 2 commits October 10, 2023 12:13
@MitchellAV MitchellAV force-pushed the develop-cyme-extract-xy-data branch from 71383f8 to 9eecddf Compare October 10, 2023 23:24
@dchassin dchassin self-requested a review October 11, 2023 14:13
dchassin
dchassin requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@dchassin dchassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments on autotests: remove check for mdb-schema. This should no longer be needed and it doesn't work on all platforms anyway.

converters/autotest/test_mdb2glm_xy_coordinates.glm Show resolved Hide resolved
converters/autotest/test_mdbtable2glm.glm Show resolved Hide resolved
converters/autotest/test_mdbtable2glmobject.glm Show resolved Hide resolved
MitchellAV and others added 3 commits October 11, 2023 18:24
@MitchellAV
Removed check for mdbtools for autotests involving mdb converter
d323900 
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
Merge branch 'develop' into develop-cyme-extract-xy-data
b17c572
@MitchellAV
Removed relative path for output filename to see if that is causing i…
d98882a 
…nconsistent validation failures

Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
@dchassin dchassin merged commit af96ff5 into arras-energy:develop Oct 12, 2023
2 checks passed
dchassin pushed a commit that referenced this pull request Oct 12, 2023
@MitchellAV @dchassin
Fix xy coordinate data extract from cyme converter (#111)
a0177bb 
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Co-authored-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
dchassin pushed a commit that referenced this pull request Oct 16, 2023
@MitchellAV @dchassin
Fix xy coordinate data extract from cyme converter (#111)
590e681 
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Co-authored-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
dchassin pushed a commit that referenced this pull request Oct 18, 2023
@MitchellAV @dchassin
Fix xy coordinate data extract from cyme converter (#111)
afd664f 
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Co-authored-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
dchassin pushed a commit to dchassin/gridlabd that referenced this pull request Jan 11, 2024
@MitchellAV
Fix xy coordinate data extract from cyme converter (arras-energy#111)
d9105f1 
Signed-off-by: Mitchell Victoriano <mitchell.victoriano@gmail.com>
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Co-authored-by: David P. Chassin <dchassin@slac.stanford.edu>
Signed-off-by: David P. Chassin <david.chassin@me.com>
Signed-off-by: David P. Chassin <dchassin@slac.stanford.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchassin dchassin dchassin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Next patch update
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MitchellAV @dchassin