Mobile support (android, ios) #547
Conversation
using fyne for mobile platforms
| job.NewRunner(runnerConfigOptions, jobsGlobalConfig, reporter).Run(ctx, logger) | ||
| runner := job.NewRunner(runnerConfigOptions, jobsGlobalConfig, reporter) | ||
|
|
||
| if mobile.IsMobile { |
There was a problem hiding this comment.
I would suggest to use another main_mobile.go to start a runner. In this case it even simpler to do it in separate repo and use 1000n as a dependency, as @arriven proposed before.
There was a problem hiding this comment.
so you would copy all main's content to it as well?.. imo it's not robust. Or how would you use this main's content? Is it possible to run it as a plain function inside another main?
Initially I tried having an all contained file with init() which runs everything without any need to modify main, but unfortunately fyne doesn't allow running its main loop not in the main thread.
There was a problem hiding this comment.
What about moving generic part of main to some API-like function, and then call it from other projects like a mobile app? I'm ok with mobile app be a part of main repo, but @arriven said that it is hard to support for him.
There was a problem hiding this comment.
In this case you don't need to support anything - no manifests, no stuff - just a bit of code which introduces something where to show the output. And you just build it for androids (and ios, but I didn't test that).
Anyway, even if a separate repo is to be pursued, we would need to make changes similar to turning the whole app into a "lib" and then having main.go just plug and run it. @arriven are you ok with that? would it still be preferable?
P.S. I personally would prefer to just have another build artifact with each release, it would guarantee there will be fresh releases as long as this project is alive. And just imagine the potential wider number of users. Otherwise imo it's pretty likely the "mobile" repo will die as several already made attempts did - like the reference one, https://github.com/zlaya-sobaka/db1000n_mobile.
But it's not up to me, so if this code helps somebody - great!
Description
Made with
fyne- a terminal emulator which supports text selection and copying; for mobile platforms. Also respects dark and light themes. If you remove the theming code - the terminal is only 65 lines long. Note: it doesn't need any manifests - fyne enables networking / internet access by default.Shout-out to @zlaya-sobaka for their repo https://github.com/zlaya-sobaka/db1000n_mobile which was an inspiration.
How to build
then
fyne installorgo install fyne.io/fyne/v2/cmd/fyneThen have Java SDK and NDK installed (or just extracted somewhere) and make sure
NDK_HOMEis properly set. To build for all possible android devices you need an NDK withandroid16compilers (at least fyne demanded them from me) - like r19, but I bet there are newer versions which have those too. The newest version of NDK doesn't. But it is also possible to limit cpu architectures and not build all possible variants.Then just run
fyne package -os android -appID com.some.idand you get an .apk file which you just send or upload to any android device and install.It is also possible to build a release build with
fyne releaseand have it published to PlayStore, but I doubt they will pass it there. Building for IOS is possible too, but I didn't try it yet (described here https://developer.fyne.io/started/mobile).Type of change
TBD