Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Circuit Breaker & remove Arrow Fx Coroutines dependency from Resilience #2905

Merged
merged 32 commits into from
Mar 14, 2023

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented Jan 26, 2023

  • Switch to TimeMark instead of timeMillis
  • Introduce OpeningStrategy
  • Add SlidingWindow OpeningStrategy
  • Remove dependency on Bracket / Arrow Fx Coroutines from Arrow Fx Resilience

@nomisRev nomisRev added arrow-fx Tickets belonging to Arrow Fx 1.2.0 Tickets belonging to 1.1.2 labels Jan 26, 2023
@nomisRev
Copy link
Member Author

There is currently a problem where Kotest is stuck on 1.6.x, and there was a breaking change in kotlin.time.* in 1.7 meaning both are not compatible with each-other.

This makes the tests fail with:

Found interface kotlin.time.TimeMark, but class was expected
java.lang.IncompatibleClassChangeError: Found interface kotlin.time.TimeMark, but class was expected

@franciscodr franciscodr marked this pull request as ready for review March 7, 2023 14:20
Copy link
Member Author

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franciscodr looks great! 👏 👏 Thanks for tacking this on 🙏 (I cannot approve my won PR 😅).

nit: I think 500_000 iterations for JVM is really excessive for stack-safety test 😂
Can't remember where that number came from. We used to have it around 20_000 for JVM/Native, and 5000 for JS IIRC..

nit: common native code can also be put in nativeMain, and they don't have to repeat it for every platform.

We can look into both nits at a later time, they're not-blocking for this PR IMO.

Copy link
Member Author

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @franciscodr. Awesome work, thank you 🙌
Just a couple of nits, and suggestions ☺️

Copy link
Member Author

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small nits:

  1. Incorrect usage of compareAndSet
  2. Mistake in my previous suggestion.

@nomisRev nomisRev merged commit 210ee5a into main Mar 14, 2023
@nomisRev nomisRev deleted the sv-update-circuit-breaker branch March 14, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.2.0 Tickets belonging to 1.1.2 arrow-fx Tickets belonging to Arrow Fx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants