Option: deprecate or, orElse and unzip #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomisRev
requested review from
serras,
raulraja,
franciscodr,
myuwono and
a team
Kover Report
|
myuwono
approved these changes
Feb 25, 2023
serras
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to deprecate
or,orElsesince they overlap withrecoverandEitherdoesn't have this API.Similarly I propose to deprecate
unzipsince I find it a rather obscure API that is unmatched inEither, or does this API make sense forOptionbut not forEither?Additionally, in https://github.com/arrow-kt/arrow/pull/2935/files#r1117382480 I also proposed to deprecate
combinefor removal which overlaps withoption { combine(a.bind(), b.bind()) }.