Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ctx inconsistency #2956

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Fix ctx inconsistency #2956

merged 1 commit into from
Mar 3, 2023

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented Mar 3, 2023

One of the 4 signatures in parMap has param name ctx instead of context. This PR fixes the inconsistency.
This code is not released yet, so there is no source compatibility issues.

@nomisRev nomisRev added the 1.2.0 Tickets belonging to 1.1.2 label Mar 3, 2023
@nomisRev nomisRev requested review from serras, franciscodr, i-walker and a team March 3, 2023 08:53
serras
serras approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@serras serras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I miss my two-letter-variable-name days in Haskell...

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Kover Report

File Coverage [98.21%]
arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/ParMap.kt 98.21%
Total Project Coverage 43.86%

@nomisRev
Copy link
Member Author

nomisRev commented Mar 3, 2023

@serras We can do the same in our production code 🤪 In Arrow I think it's good practice to follow the same naming conventions as Kotlin Std and KotlinX Coroutines. Otherwise everything would remain f, ctx, n, etc 😁

@nomisRev nomisRev merged commit f110e6f into main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscodr franciscodr franciscodr approved these changes

@serras serras serras approved these changes

@i-walker i-walker Awaiting requested review from i-walker

Assignees
No one assigned
Labels
1.2.0 Tickets belonging to 1.1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nomisRev @serras @franciscodr