Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly escape class names in Optics KSP when a property clashes with a package name #3326

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Correctly escape class names in Optics KSP when a property clashes with a package name #3326

merged 1 commit into from
Dec 20, 2023

Conversation

serras
Copy link
Member

@serras serras commented Dec 20, 2023

Fixes #3134

@serras serras requested review from nomisRev and a team December 20, 2023 11:17
@serras serras self-assigned this Dec 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

Kover Report

File Coverage [92.17%]
arrow-libs/optics/arrow-optics-ksp-plugin/src/main/kotlin/arrow/optics/plugin/internals/dsl.kt 88.19%
arrow-libs/optics/arrow-optics-ksp-plugin/src/main/kotlin/arrow/optics/plugin/internals/utils.kt 98.84%
Total Project Coverage 54.52%

nomisRev
nomisRev approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @serras for fixing this issue so quickly! 🙌 🥳

@serras serras merged commit 46ad6fa into main Dec 20, 2023
11 checks passed
@serras serras deleted the serras/fix-3134 branch December 20, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@raulraja raulraja raulraja approved these changes

Assignees

@serras serras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optics KSP Plugin breaks if the word “data” is part of the package
3 participants
@serras @raulraja @nomisRev