Implement sealed class Lenses #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksym Moroz <maksymmoroz@duck.com>
maksym-moroz
force-pushed
the
maksymmoroz/features/implement-sealed-class-lenses
branch
from
5b97025
to
fb9c6dd
Compare
|
@maksym-moroz can you run the |
|
@serras I did just that and it didn't show any issues with build |
|
The automatic Spotless commit was not working, I've done it manually. This should (hopefully) turn the build green. |
serras
requested changes
Jan 30, 2024
arrow-libs/optics/arrow-optics-ksp-plugin/src/test/kotlin/arrow/optics/plugin/LensTests.kt
Outdated
Show resolved
Hide resolved
This was referenced Feb 8, 2024
serras
added a commit
to arrow-kt/arrow-website
that referenced
this pull request
Feb 28, 2024
Documentation related to arrow-kt/arrow#3359
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2829
Implement and enable Lens generation for sealed class properties when these properties are abstract and without extension receiver, subclasses are data classes that override properties in the constructor.
If that's not the case emit an info log message explaining why Lens is not being generated.
Additional cleanup to target logic.
All tests pass