fix: Extend DataTableColumn type column length (pinterest#1121)

querybook/migrations/versions/27ed76f75106_extend_datatablecolumn_type_length.py

@@ -0,0 +1,40 @@
+"""Extend DataTableColumn type length
+
+Revision ID: 27ed76f75106
+Revises: 63bde0162416
+Create Date: 2023-01-05 09:43:06.639449
+
+"""
+from alembic import op
+import sqlalchemy as sa
+from sqlalchemy.dialects import mysql
+
+# revision identifiers, used by Alembic.
+revision = "27ed76f75106"
+down_revision = "63bde0162416"
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column(
+        "data_table_column",
+        "type",
+        nullable=True,
+        existing_type=sa.String(length=255),
+        type_=sa.String(length=4096),
+    )
+    # ### end Alembic commands ###
+
+
+def downgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column(
+        "data_table_column",
+        "type",
+        nullable=True,
+        existing_type=sa.String(length=4096),
+        type_=sa.String(length=255),
+    )
+    # ### end Alembic commands ###

querybook/server/const/db.py

@@ -3,6 +3,7 @@
 now = datetime.datetime.utcnow
 utf8mb4_name_length = 191
 name_length = 255
+type_length = 4096
 password_length = 255
 description_length = 5000
 text_length = 65535

querybook/server/models/metastore.py

@@ -9,6 +9,7 @@
     description_length,
     url_length,
     mediumtext_length,
+    type_length,
 )
 from const.metastore import DataTableWarningSeverity
 from lib.sqlalchemy import CRUDMixin, TruncateString
@@ -283,7 +284,7 @@ class DataTableColumn(TruncateString("name", "type", "comment"), Base):
     updated_at = sql.Column(sql.DateTime, default=now)
 
     name = sql.Column(sql.String(length=name_length), index=True)
-    type = sql.Column(sql.String(length=name_length))
+    type = sql.Column(sql.String(length=type_length))
 
     comment = sql.Column(sql.String(length=description_length))
     description = sql.Column(sql.Text(length=mediumtext_length))