Redirect stdout from custom command to the log files #1008
Conversation
|
For this feature request: #1007 |
core/app.py
Outdated
| subprocess.Popen(exename + args, shell=True, cwd=path) | ||
| p = subprocess.Popen(exename + args, shell=True, cwd=path, stdout=subprocess.PIPE, stderr=subprocess.STDOUT) | ||
| output = p.stdout.read() | ||
| logging.info("Custom command %s %s:\n %s", exename, args, output) |
There was a problem hiding this comment.
All other log entries are single line, I would prefer to keep these entries single line as well.
core/app.py
Outdated
| subprocess.Popen(dupe_cmd, shell=True) | ||
| p = subprocess.Popen(dupe_cmd, shell=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT) | ||
| output = p.stdout.read() | ||
| logging.info("Custom command %s:\n %s", dupe_cmd, output) |
There was a problem hiding this comment.
All other log entries are single line, I would prefer to keep these entries single line as well.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks for the review and merge, out of curiosity, when are builds done? I'm having trouble creating the windows package (python38.dll not found) so was hoping to just wait for the next official build |
|
Builds currently don't have a set schedule, mainly done based on the features / bugs fixed since last release. The next release has an issue tracking its progress #1002. Currently there are a few more minor items I am considering completing before building the next release. |
No description provided.