Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to the correct architecture of SAINT #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change to the correct architecture of SAINT #6

wants to merge 1 commit into from

Conversation

Nino-SEGALA
Copy link

I've corrected the architecture of SAINT to correspond the description given in the paper

@Nino-SEGALA Nino-SEGALA mentioned this pull request Apr 26, 2022
Open
@Xemorr
Copy link

Xemorr commented May 3, 2024

This implementation uses positional encoding instead of positional embeddings, it is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nino-SEGALA @Xemorr