Use descendants on tree instead of looping [WEB-2918]

art-institute-of-chicago · Aug 23, 2024 · c79bf30 · c79bf30
1 parent 5a7e911
commit c79bf30
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/app/Presenters/Admin/DigitalPublicationArticlePresenter.php b/app/Presenters/Admin/DigitalPublicationArticlePresenter.php
@@ -61,17 +61,13 @@ public function getBrowseMoreLink($showAll = false)
 
     public function countAllChildren($entity)
     {
-        $count = 0;
-        foreach ($entity->children as $child) {
-            if ($child->type !== DigitalPublicationArticleType::Grouping) {
-                $count += 1;
-            }
+        $descendants = $entity->descendants;
 
-            if ($child->children && $child->children->count() > 0) {
-                $count += $this->countAllChildren($child);
-            }
-        }
-        return $count;
+        $filteredDescendants = $descendants->filter(function ($descendant) {
+            return $descendant->type !== DigitalPublicationArticleType::Grouping;
+        });
+
+        return $filteredDescendants->count();
     }
 
     public function references()