Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migrate:osci-publication to use migration file from osci-migration #433

Merged
merged 36 commits into from
Aug 19, 2024

Conversation

cbutcosk
Copy link
Contributor

This pull request updates migrate:osci-publication to use the sqlite database produced by the codebase in https://github.com/art-institute-of-chicago/osci-migration .

To use the new command, put the migration file from https://github.com/art-institute-of-chicago/osci-migration/blob/feature/errata-and-blocks/admin/src/data/migration.sqlite3 in your path and run twill migrate:osci-publication <id> where <id> is a publication id from the publications table (also visible here -- https://feature-errata-and-blocks--osci-migration.netlify.app ).

Copy link

sentry-io bot commented Jun 20, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/Console/Commands/MigrateOSCIPublicationOne.php

Function Unhandled Issue
App\Console\Commands\MigrateOSCIPublicationOne::handle ErrorException: SQLite3::prepare(): Unable to prepare statement: 1, no such table: publications /app/Console/Commands/MigrateOSCIPublicationOne.php in Illuminate\Fou...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link
Member

@nikhiltri nikhiltri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ⭐

@nikhiltri nikhiltri force-pushed the feature/osci-migration-update branch from 15f95f1 to 2ca0795 Compare June 25, 2024 20:56
app/Console/Commands/MigrateOSCIPublicationOne.php Outdated Show resolved Hide resolved
app/Console/Commands/MigrateOSCIPublicationOne.php Outdated Show resolved Hide resolved
app/Console/Commands/MigrateOSCIPublicationOne.php Outdated Show resolved Hide resolved
@nikhiltri nikhiltri force-pushed the feature/osci-migration-update branch from 266c987 to 931ab84 Compare July 3, 2024 15:07
@nikhiltri nikhiltri force-pushed the feature/osci-migration-update branch from a91e6f0 to 7411b49 Compare July 12, 2024 14:53
@nikhiltri nikhiltri force-pushed the feature/osci-migration-update branch 2 times, most recently from cc7d3f3 to c0c0385 Compare July 24, 2024 22:27
@nikhiltri nikhiltri force-pushed the feature/osci-migration-update branch from 3c4b166 to 38f7371 Compare August 19, 2024 14:48
Copy link

sonarcloud bot commented Aug 19, 2024

@nikhiltri nikhiltri self-requested a review August 19, 2024 16:12
@nikhiltri nikhiltri merged commit 99846f2 into develop Aug 19, 2024
3 checks passed
@nikhiltri nikhiltri deleted the feature/osci-migration-update branch August 19, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants