-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pubs FE cleanup for deploy FINAL_USE_THIS_ONE_v2 #478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change, then good to go!
@component('components.molecules._m-title-bar', [ | ||
'variation' => 'm-title-bar--compact m-title-bar--light', | ||
]) | ||
@slot('links', ((count($topLevelArticle->children) > 4 && count($topLevelArticle->children) < 8) || (count($topLevelArticle->children) > 8)) ? $topLevelArticle->present()->getBrowseMoreLink($showAll) : []) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is hard to read. I think checking if the number of children is not equal to 0, 4, or 8 might be easier to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! ⭐
a911a35
to
03f0f05
Compare
Quality Gate passedIssues Measures |
No description provided.