Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA fixes for DigiPub sticky header #482

Merged
merged 3 commits into from
Aug 23, 2024
Merged

QA fixes for DigiPub sticky header #482

merged 3 commits into from
Aug 23, 2024

Conversation

zachgarwood
Copy link
Member

@zachgarwood zachgarwood commented Aug 21, 2024 •
edited
Loading

These changes include:

  • the background color of the title/byline in the header reaches all the way to the screen edge in xlarge screen sizes
  • fix scroll jump on mobile when passing sticky TOC
  • the header image fades out/in on shrink/min-size:
Screen.Recording.2024-08-22.at.2.38.22.PM.mov

@zachgarwood zachgarwood self-assigned this Aug 21, 2024
@zachgarwood zachgarwood marked this pull request as ready for review August 22, 2024 20:06
nikhiltri
nikhiltri approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@nikhiltri nikhiltri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and ready for PM review. ⭐

Before you merge, do a git rebase origin/develop then merge with a merge commit.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@zachgarwood zachgarwood merged commit b538a44 into develop Aug 23, 2024
3 checks passed
@zachgarwood zachgarwood deleted the fix/digipub-header branch August 23, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhiltri nikhiltri nikhiltri approved these changes

@web-dev-trev web-dev-trev web-dev-trev approved these changes

Assignees

@zachgarwood zachgarwood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachgarwood @nikhiltri @web-dev-trev