Fix content jump when scrolling [PUB-229] #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change makes the sticky header only appear when it has been completely scrolled past, instead of becoming sticky when it reaches it's minimum height, then when it does appear, it covers content below it: Screen.Recording.2024-08-22.at.2.44.12.PM.mov |
zachgarwood
approved these changes
Aug 22, 2024
|
@zachgarwood sometimes the JS caches in a half loaded state or previous one. I usually restart npm run dev when swapping branches to avoid it. |
nikhiltri
force-pushed
the
fix/content-jump-when-scrolling
branch
from
ae02170
to
08388ac
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.