Add share and pdf download links to TOC [PUB-234] #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhiltri
requested changes
Aug 26, 2024
|
|
||
| <ul class="m-article-actions{{ (isset($variation)) ? ' '.$variation : '' }}" aria-labelledby="h-article-actions{{ (isset($variation)) ? $variation : '' }}"> | ||
|
|
||
| @if (empty($hideShare)) |
There was a problem hiding this comment.
I'm not sure that a slot value for hideShare and pdfDownloadPath are being passed to this molecule.
There was a problem hiding this comment.
I'm specifically looking at the call to the molecule in digitalPublicationArticleDetail.blade.php. In other places where _m-article-actions.blade.php is used to render the icons will appear, but in the case of digitalPublicationArticleDetail it calls _m-article-actions----digital-publication.blade.php directly, and should pass these values.
web-dev-trev
force-pushed
the
fix/print-icons-in-digipub-toc
branch
from
a1a7c53
to
b94304c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.