Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to add non-boundary constraints that don't affect hole detection #123

Closed
artem-ogre opened this issue Feb 24, 2023 · 0 comments
Labels
enhancement New feature or request new feature adds a new feature

Comments

@artem-ogre
Copy link
Owner

Make it possible to add constraints that don't affect triangle removal and hole detection

See #119

This PR introduces a flag on constraint edges that allows the distinction between "outer" and "inner" constraint edges, that is, edges that will be boundaries when removing the super triangle and holes, and edges that will simply be guaranteed to be part of the triangulation, but do not describe the boundaries of the triangulation, and will be ignored during "hole-detection".
I did not find any other way to achieve this, but maybe there's a much simpler way?
In any case, I wanted to publish our changes, and share them in this way. If you want to merge this, I'll gladly work in any comments that you might have.

@artem-ogre artem-ogre added enhancement New feature or request new feature adds a new feature labels Feb 24, 2023
artem-ogre added a commit that referenced this issue Feb 24, 2023
artem-ogre added a commit that referenced this issue Feb 24, 2023
artem-ogre added a commit that referenced this issue Apr 13, 2023
artem-ogre added a commit that referenced this issue Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature adds a new feature
Projects
None yet
Development

No branches or pull requests

1 participant