Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete handling of SuperGeometryType::Enum::Custom #31

Closed
LeoPizzo1 opened this issue Feb 23, 2021 · 2 comments
Closed

Incomplete handling of SuperGeometryType::Enum::Custom #31

LeoPizzo1 opened this issue Feb 23, 2021 · 2 comments

Comments

@LeoPizzo1
Copy link

Ciao,

I implemented the usage of custom geometry initialization and I have seen that the library is not correctly handling the case.
The vertex ordering was not correctly maintained after a call to eraseOuterTriangles or eraseOuterTrianglesAndHoles, thus making impossible to remap correctly the indexes.
I found 2 points where I had to change the code in order to correctly execute:

  • void Triangulation::eraseSuperTriangleVertices(): I had to check if the geometry is custom, and if it is, the function should do nothing.
  • void Triangulation::eraseSuperTriangle(): same as previous one.
  • void Triangulation::initializedWithCustomSuperGeometry(): I need to add the line m_superGeomType = SuperGeometryType::Enum::Custom;

I didn't check other locations, maybe you will see some other areas where to take a look.
Enclosed here the changed file.

CDT.zip

@artem-ogre
Copy link
Owner

Ciao and thank you for the suggestion!
Could you please confirm that 01f40d5 fixes it?

@artem-ogre
Copy link
Owner

I'm closing this issue due to inactivity. @LeoPizzo1 feel free to re-open it if the fix does not work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants