[Autolink Extract] Keep a set of linker flags instead of vector

Otherwise we can duplicate linker flags across input binaries, which can result in very large linkerr invocation commands. Resolves swiftlang#58380
artemcm · May 20, 2022 · d2f4a98 · d2f4a98
1 parent 415c5c1
commit d2f4a98
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 9 deletions.
diff --git a/lib/DriverTool/autolink_extract_main.cpp b/lib/DriverTool/autolink_extract_main.cpp
@@ -18,6 +18,7 @@
 
 #include <string>
 #include <vector>
+#include <unordered_set>
 
 #include "swift/AST/DiagnosticsFrontend.h"
 #include "swift/Frontend/Frontend.h"
@@ -112,6 +113,7 @@ class AutolinkExtractInvocation {
 /// Return 'true' if there was an error, and 'false' otherwise.
 static bool
 extractLinkerFlagsFromObjectFile(const llvm::object::ObjectFile *ObjectFile,
+                                 std::unordered_set<std::string> &SeenLinkerFlags,
                                  std::vector<std::string> &LinkerFlags,
                                  CompilerInstance &Instance) {
   // Search for the section we hold autolink entries in
@@ -140,8 +142,11 @@ extractLinkerFlagsFromObjectFile(const llvm::object::ObjectFile *ObjectFile,
       llvm::SmallVector<llvm::StringRef, 4> SplitFlags;
       SectionData->split(SplitFlags, llvm::StringRef("\0", 1), -1,
                          /*KeepEmpty=*/false);
-      for (const auto &Flag : SplitFlags)
-        LinkerFlags.push_back(Flag.str());
+      for (const auto &Flag : SplitFlags) {
+        auto SeenFlagsInsertResult = SeenLinkerFlags.insert(Flag.str());
+        if (SeenFlagsInsertResult.second == true)
+          LinkerFlags.push_back(Flag.str());
+      }
     }
   }
   return false;
@@ -152,6 +157,7 @@ extractLinkerFlagsFromObjectFile(const llvm::object::ObjectFile *ObjectFile,
 /// 'true' if there was an error, and 'false' otherwise.
 static bool
 extractLinkerFlagsFromObjectFile(const llvm::object::WasmObjectFile *ObjectFile,
+                                 std::unordered_set<std::string> &SeenLinkerFlags,
                                  std::vector<std::string> &LinkerFlags,
                                  CompilerInstance &Instance) {
   // Search for the data segment we hold autolink entries in
@@ -164,8 +170,11 @@ extractLinkerFlagsFromObjectFile(const llvm::object::WasmObjectFile *ObjectFile,
       llvm::SmallVector<llvm::StringRef, 4> SplitFlags;
       SegmentData.split(SplitFlags, llvm::StringRef("\0", 1), -1,
                         /*KeepEmpty=*/false);
-      for (const auto &Flag : SplitFlags)
-        LinkerFlags.push_back(Flag.str());
+      for (const auto &Flag : SplitFlags) {
+        auto SeenFlagsInsertResult = SeenLinkerFlags.insert(Flag.str());
+        if (SeenFlagsInsertResult.second == true)
+          LinkerFlags.push_back(Flag.str());
+      }
     }
   }
   return false;
@@ -178,12 +187,13 @@ extractLinkerFlagsFromObjectFile(const llvm::object::WasmObjectFile *ObjectFile,
 static bool extractLinkerFlags(const llvm::object::Binary *Bin,
                                CompilerInstance &Instance,
                                StringRef BinaryFileName,
+                               std::unordered_set<std::string> &SeenLinkerFlags,
                                std::vector<std::string> &LinkerFlags) {
   if (auto *ObjectFile = llvm::dyn_cast<llvm::object::ELFObjectFileBase>(Bin)) {
-    return extractLinkerFlagsFromObjectFile(ObjectFile, LinkerFlags, Instance);
+    return extractLinkerFlagsFromObjectFile(ObjectFile, SeenLinkerFlags, LinkerFlags, Instance);
   } else if (auto *ObjectFile =
                  llvm::dyn_cast<llvm::object::WasmObjectFile>(Bin)) {
-    return extractLinkerFlagsFromObjectFile(ObjectFile, LinkerFlags, Instance);
+    return extractLinkerFlagsFromObjectFile(ObjectFile, SeenLinkerFlags, LinkerFlags, Instance);
   } else if (auto *Archive = llvm::dyn_cast<llvm::object::Archive>(Bin)) {
     llvm::Error Error = llvm::Error::success();
     for (const auto &Child : Archive->children(Error)) {
@@ -197,7 +207,7 @@ static bool extractLinkerFlags(const llvm::object::Binary *Bin,
         return true;
       }
       if (extractLinkerFlags(ChildBinary->get(), Instance, BinaryFileName,
-                             LinkerFlags)) {
+                             SeenLinkerFlags, LinkerFlags)) {
         return true;
       }
     }
@@ -228,6 +238,7 @@ int autolink_extract_main(ArrayRef<const char *> Args, const char *Argv0,
   }
 
   std::vector<std::string> LinkerFlags;
+  std::unordered_set<std::string> SeenLinkerFlags;
 
   // Extract the linker flags from the objects.
   for (const auto &BinaryFileName : Invocation.getInputFilenames()) {
@@ -245,7 +256,7 @@ int autolink_extract_main(ArrayRef<const char *> Args, const char *Argv0,
     }
 
     if (extractLinkerFlags(BinaryOwner->getBinary(), Instance, BinaryFileName,
-                           LinkerFlags)) {
+                           SeenLinkerFlags, LinkerFlags)) {
       return 1;
     }
   }

diff --git a/test/AutolinkExtract/import.swift b/test/AutolinkExtract/import.swift
@@ -1,10 +1,16 @@
 // RUN: %empty-directory(%t)
 // RUN: %target-swiftc_driver -emit-module -emit-module-path %t/empty.swiftmodule -module-name empty -module-link-name empty %S/empty.swift
 // RUN: %target-swiftc_driver -c %s -I %t -o %t/import_experimental.o
-// RUN: %target-swift-autolink-extract %t/import_experimental.o -o - | %FileCheck --check-prefix CHECK-%target-object-format %s
+// RUN: %target-swiftc_driver -c %s -I %t -o %t/import_experimental_again.o
+// RUN: %target-swift-autolink-extract %t/import_experimental.o %t/import_experimental_again.o -o - | %FileCheck --check-prefix CHECK-%target-object-format %s
+
+// RUN: %target-swift-autolink-extract %t/import_experimental.o %t/import_experimental_again.o -o - | %FileCheck --check-prefix UNIQUE %s
 
 // REQUIRES: autolink-extract
 
+// UNIQUE-COUNT-1: -lempty
+// UNIQUE-COUNT-1: -lswiftCore
+
 // CHECK-elf-DAG: -lswiftCore
 // CHECK-elf-DAG: -lempty