-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement conversion webhook #355
base: main
Are you sure you want to change the base?
Conversation
This needs a re base from main, the conversion got a little easier after dropping the two problematic float variables. It will allow us to cleanly move to a v1 without interruption in the future so it is a great feature. nice! |
do we need to create a self signed cert as part of the build? Having something hard coded that can expire will be problematic in the future I guess. |
08723b5
to
0f3c949
Compare
Signed-off-by: ruromero <rromerom@redhat.com>
0f3c949
to
2b2efee
Compare
@ruromero We may need add conversion for security and address crds, may be do that separately. |
another problem with "static certs" is that it tied to a specific namespace. That's because the cert's CN name must match the webhook service name (so that the service's hostname ..svc can match the CN so it can be trusted). |
on other thing, If I set ENABLE_WEBHOOKS to false and I can't deploy a v1beta1 CR. |
@gaohoward I did not test with OLM only on OpenShift with basic deployment, as you noticed, static certs won't be trusted if it is deployed in a different namespace. I just used the existing cert secret generated with the operator-sdk.
That is correct, you have to deploy it with the envVar set to true, I can make it the default as this PR requires webhooks to be deployed. |
I have updated the kustomize patch during the |
Signed-off-by: ruromero <rromerom@redhat.com>
4abcc8f
to
b0ef5dc
Compare
Signed-off-by: ruromero <rromerom@redhat.com>
32874cc
to
18b00c2
Compare
@ruromero Hi, I got some error using the cert manager option. Below is what I did
Any idea? |
Make sure you're creating the resource in the same namespace where the operator is deployed. Steps.
|
@@ -8,9 +8,10 @@ VERSION ?= 1.0.0 | |||
KUBE_CLI=kubectl | |||
OPERATOR_VERSION := 1.0.6 | |||
OPERATOR_ACCOUNT_NAME := activemq-artemis-operator | |||
OPERATOR_CLUSTER_ROLE_NAME := operator-role | |||
OPERATOR_CLUSTER_ROLE_NAME := operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gtully why was this working before?
c46a2b6
to
d33a37b
Compare
@gaohoward @gtully I have tested the deployment on minikube and OCP with cert-manager and also on OCP with OLM (see the new target for deploying the catalog source) but another pair of eyes would help in case I missed something. Thanks |
Signed-off-by: ruromero <rromerom@redhat.com>
d33a37b
to
55922d0
Compare
4450ca1
to
dc7da46
Compare
as discussed with @ruromero I'll be closing this PR and send a new one for review. |
a9861a2
to
6ea4c00
Compare
Implement conversion webhook between ActiveMQArtemises v2alpha5 and v1beta1