-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#910] Remove Scaledown CRD #911
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great cleanup!
The only blocker is a release that includes d7babc9
@@ -40,125 +35,86 @@ var controllers map[string]*draincontroller.Controller = make(map[string]*drainc | |||
|
|||
var kubeClient *kubernetes.Clientset | |||
|
|||
// ActiveMQArtemisScaledownReconciler reconciles a ActiveMQArtemisScaledown object | |||
type ActiveMQArtemisScaledownReconciler struct { | |||
type ActiveMQArtemisMessageMigrationControl struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filename is still activemqartemisscaledown_controller.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it should be renamed. Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed it to draft. It's a major change we should try not be included in minor releases.
efc57af
to
931bf99
Compare
No description provided.