Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jolokia.go #926

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nanmozhi22
Copy link

Disabled TLS certificate check

Disabled TLS certificate check

Signed-off-by: An, Nanmozhi <Nanmozhi.An@fmr.com>
@brusdev
Copy link
Contributor

brusdev commented May 14, 2024

@Nanmozhi22 can you create an issue at https://github.com/artemiscloud/activemq-artemis-operator/issues/new/choose and add the number of the issue at the beginning of the commit message?

@Nanmozhi22
Copy link
Author

@brusdev Thank you for your response!

But I have already opened an issue #919 and committed the code .

Do you still want me to create a new issue and the number of the commit ? It would be great if you can clarify this.

Thanks
Nan

@brusdev
Copy link
Contributor

brusdev commented May 15, 2024

@Nanmozhi22 #919 is fine, you just need to add the number of the issue at the beginning of the commit message, i.e.

[#919] Update jolokia.go

@brusdev
Copy link
Contributor

brusdev commented May 15, 2024

I'm wondering if this change can break deployment with a console secured by self signed certificates

@Nanmozhi22
Copy link
Author

@brusdev Thank for the update! Do you think this PR can cause any potential issue ?

@brusdev
Copy link
Contributor

brusdev commented May 15, 2024

@Nanmozhi22 I think this PR is a good security improvement but we need to figure out a solution for deployments with a console secured by self signed certificates

@Nanmozhi22
Copy link
Author

@brusdev got it , Just curious until if we figure out a solution this PR can't be merged ?

@brusdev
Copy link
Contributor

brusdev commented May 16, 2024

@brusdev got it , Just curious until if we figure out a solution this PR can't be merged ?

@Nanmozhi22 I don't think so, I'll convert it to draft

@brusdev brusdev marked this pull request as draft May 16, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants