Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out hashtags within an url when listing tags #265

Closed
petobens opened this issue Nov 20, 2023 · 1 comment · Fixed by #266
Closed

Filter out hashtags within an url when listing tags #265

petobens opened this issue Nov 20, 2023 · 1 comment · Fixed by #266
Labels
bug Something isn't working

Comments

@petobens
Copy link

Following my comment #262 (comment) if I have an url like https://docs.google.com/spreadsheets/d/1Rr7GcfjUwhZfylUk0FGL0Et4kYF5etl49OpRwRmhhlg/edit#gid=1116260529&range=D12 marksman will treat this as tag. Is it possible to filter out these cases?

Dunno if there are other edge cases that need futher filtering out.
@petobens petobens changed the title Filter out hastags within an url when listing tags Filter out hashtags within an url when listing tags Nov 20, 2023
@artempyanykh artempyanykh added the bug Something isn't working label Nov 20, 2023
@artempyanykh
Copy link
Owner

Thanks for reporting @petobens! Yeah, parsing of tags needs to be fixed.

TheBlob42 added a commit to TheBlob42/marksman that referenced this issue Nov 21, 2023
@TheBlob42
fix: Don't parse tags inside words & URLs
178c3f0 
fixes artempyanykh#265
TheBlob42 added a commit to TheBlob42/marksman that referenced this issue Nov 21, 2023
@TheBlob42
fix: Don't parse tags inside words & URLs
0ef0805 
fixes artempyanykh#265
@TheBlob42 TheBlob42 mentioned this issue Nov 21, 2023
Merged
artempyanykh pushed a commit that referenced this issue Nov 22, 2023
@TheBlob42 @artempyanykh
fix: Don't parse tags inside words & URLs
b846249 
fixes #265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Don't parse tags inside words & URLs TheBlob42/marksman
2 participants
@artempyanykh @petobens