fix: Check for a bogus root folder in workspace/didChangeWorkspaceFolders request #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ders request Sometimes, LSP clients can send bogus folders (CWD, or homedir) as part of added folders in didChangeWorkspaceFolders. Whenever this happens marksman treats the root as the real root of the project folders and recursively scans/indexes mardown documents underneath.This is problematic when such root is a homedir because it makes marksman scan too much and potentially fail. Fixes #377 Potentially, addresses #373 too stack-info: PR: #380, branch: artempyanykh/stack/17
artempyanykh
added a commit
that referenced
this pull request
Dec 14, 2024
…ders request Sometimes, LSP clients can send bogus folders (CWD, or homedir) as part of added folders in didChangeWorkspaceFolders. Whenever this happens marksman treats the root as the real root of the project folders and recursively scans/indexes mardown documents underneath.This is problematic when such root is a homedir because it makes marksman scan too much and potentially fail. Fixes #377 Potentially, addresses #373 too stack-info: PR: #380, branch: artempyanykh/stack/17
artempyanykh
force-pushed
the
artempyanykh/stack/17
branch
from
9130a7c to
df05f53
Compare
artempyanykh
force-pushed
the
artempyanykh/stack/16
branch
from
05aa0fb to
8da020f
Compare
This was referenced Dec 14, 2024
Closed
artempyanykh
force-pushed
the
artempyanykh/stack/16
branch
from
8da020f to
230effb
Compare
artempyanykh
added a commit
that referenced
this pull request
Dec 14, 2024
…ders request Sometimes, LSP clients can send bogus folders (CWD, or homedir) as part of added folders in didChangeWorkspaceFolders. Whenever this happens marksman treats the root as the real root of the project folders and recursively scans/indexes mardown documents underneath.This is problematic when such root is a homedir because it makes marksman scan too much and potentially fail. Fixes #377 Potentially, addresses #373 too stack-info: PR: #380, branch: artempyanykh/stack/17
artempyanykh
force-pushed
the
artempyanykh/stack/17
branch
2 times, most recently
from
4134fd0 to
410bd1f
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
fix: Check for a bogus root folder in workspace/didChangeWorkspaceFolders request
Sometimes, LSP clients can send bogus folders (CWD, or homedir) as part
of added folders in didChangeWorkspaceFolders. Whenever this happens
marksman treats the root as the real root of the project folders and
recursively scans/indexes mardown documents underneath.This is
problematic when such root is a homedir because it makes marksman scan
too much and potentially fail.
Fixes #377
Potentially, addresses #373 too