New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: Do not fail when neither worspace folders nor workspace root is provided #68

Merged

artempyanykh merged 1 commit into main from no-fail-on-empty-root

Sep 2, 2022

Owner

artempyanykh commented Sep 2, 2022 •

edited

Loading

Previously, when neither the workspace folders, root_uri, nor root_path were provided server would deliberately fail.

This is not the best experience because

the users can get confused
the client can still add workspace folders later via a notification.


          infra: Do not fail when neither worspace folders nor workspace root i…

dfd8192

…s provided

artempyanykh merged commit 341df1b into main

artempyanykh deleted the no-fail-on-empty-root branch

September 2, 2022 17:14

artempyanykh mentioned this pull request

Server never initializes if no workspaceFolders are given #66

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet