Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log callbacks for FFprobe includes the executionId of a previous async FFmpeg execution #1

Closed
tanersener opened this issue Sep 26, 2020 · 2 comments
Assignees
Labels
android Affect Android platform apple Affect Apple platforms bug Something isn't working development-branch Affects development branch fixed-in-v4.4 Fixed in release v4.4 library Affects the library mobile-ffmpeg Originates from MobileFFmpeg

Comments

@tanersener
Copy link
Collaborator

tanersener commented Sep 26, 2020

Current Behaviour
When the same thread calls Config.ffmpegExecute() first and FFprobe.execute() later, log callbacks received for FFprobe includes the executionId of the ffmpeg execution.

Expected Behaviour
FFprobe does not support async operations. So, log callbacks for FFprobe should always have executionId = 0.

Environment
This issue originates from MobileFFmpeg v4.4 and v4.4.LTS, affects all platforms including react-native and flutter plugins based on MobileFFmpeg.

@tanersener tanersener added the bug Something isn't working label Sep 26, 2020
@tanersener tanersener self-assigned this Sep 26, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tanersener
Copy link
Collaborator Author

Fixed in v4.4 and v4.4.LTS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Affect Android platform apple Affect Apple platforms bug Something isn't working development-branch Affects development branch fixed-in-v4.4 Fixed in release v4.4 library Affects the library mobile-ffmpeg Originates from MobileFFmpeg
Projects
None yet
Development

No branches or pull requests

1 participant