Remove alloc feature
#160
Merged
Remove alloc feature
#160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopopolo
force-pushed
the
lopopolo/alloc-required-no-feature
branch
from
d598a93 to
ef16d8e
Compare
`boba` has a required dependency on the `alloc` crate, but gates the availability of the `alloc` crate with the `alloc` feature. `boba` does not build with no default features as a result. The docs lead me to believe this was intentional, but with new CI steps in #159, all Artichoke crates must build and pass a docs build with no default features. This will require a semver major bump.
lopopolo
force-pushed
the
lopopolo/alloc-required-no-feature
branch
from
ef16d8e to
84cdd25
Compare
This was referenced Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bobahas a required dependency on thealloccrate, but gates theavailability of the
alloccrate with theallocfeature.bobadoes not build with no default features as a result. The docslead me to believe this was intentional, but with new CI steps in #159,
all Artichoke crates must build and pass a docs build with no default
features.
This will require a semver major bump.