Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional tests to achieve 100% code coverage #165

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Add additional tests to achieve 100% code coverage #165

merged 3 commits into from
Sep 14, 2022

Conversation

lopopolo
Copy link
Member

No description provided.

@lopopolo
Remove codecov uncovered lines in exhaustive test assertions
a8501fa 
Assert messages should be uncovered since we don't want these tests to fail.
Make the assertion one SLOC to mask this false positive and enforce it with
rustfmt skip attributes.
@lopopolo lopopolo added C-quality Category: Refactoring, cleanup, and quality improvements. A-folding Area: Unicode case folding. labels Sep 14, 2022
@lopopolo
Copy link
Member Author

Code coverage is 100% as of this commit:

On trunk: 
coveragePercent = 99.79
linesCovered = 4837
linesMissed = 10
linesTotal = 4847

On PR branch: 
coveragePercent = 100.0
linesCovered = 4883
linesMissed = 0
linesTotal = 4883

@lopopolo lopopolo merged commit e9d842f into trunk Sep 14, 2022
@lopopolo lopopolo deleted the lopopolo/coverage-100 branch September 14, 2022 04:41
@lopopolo lopopolo mentioned this pull request Sep 17, 2022
Merged
@lopopolo lopopolo mentioned this pull request May 31, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-folding Area: Unicode case folding. C-quality Category: Refactoring, cleanup, and quality improvements.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lopopolo