Skip to content

Commit

Permalink
Update rust-toolchain and emscripten-toolchain to LLVM 12
Browse files Browse the repository at this point in the history
Artichoke only compiles with Rust 1.54.0. Rust 1.54.0 is based on LLVM
12 (rust-lang/rust#81451). To ensure the `emcc` compiled sources interop
with Rust code, it is important to use an `emsdk` version that is ~close
to when it was branched from LLVM 12.

According to the release notes [0], 2.0.23 - 05/26/2021 release is the
first to be based on LLVM 12.

However, Rust depends on a stubbed function in the emsdk c++ ABI that
was removed in 2.0.10. According to rust-lang/rust#85821, we might have
luck compiling with 2.0.9

[0]: https://emscripten.org/docs/introducing_emscripten/release_notes.html

emscripten-toolchain
  • Loading branch information
lopopolo committed Aug 5, 2021
1 parent 55c239e commit c67a20a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion emscripten-toolchain
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.39.20-upstream
2.0.9-upstream
2 changes: 1 addition & 1 deletion rust-toolchain
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.51.0
1.54.0

0 comments on commit c67a20a

Please sign in to comment.