Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter coverage results #356

Merged
merged 5 commits into from
Aug 22, 2022
Merged

Filter coverage results #356

merged 5 commits into from
Aug 22, 2022

Conversation

x-hgg-x
Copy link
Contributor

@x-hgg-x x-hgg-x commented Aug 22, 2022

Fixes #349.

@lopopolo
Copy link
Member

Coverage changes:

  • boba: no change
  • focaccia: no change, but Move exhaustive integration tests to unit tests focaccia#157 was previously landed
  • intaglio: improvement, matches badge
    On trunk: 
    coveragePercent = 36.4
    linesCovered = 6111
    linesMissed = 10676
    linesTotal = 16787
    
    On PR branch: 
    coveragePercent = 91.3
    linesCovered = 3419
    linesMissed = 326
    linesTotal = 3745
    
  • posix-space: no change
  • rand_mt: improvement, matches badge
    On trunk: 
    coveragePercent = 94.43
    linesCovered = 1102
    linesMissed = 65
    linesTotal = 1167
    
    On PR branch: 
    coveragePercent = 99.72
    linesCovered = 1051
    linesMissed = 3
    linesTotal = 1054
    
  • raw-parts: no change
  • roe: improvement, matches badge
    On trunk: 
    coveragePercent = 78.32
    linesCovered = 1514
    linesMissed = 419
    linesTotal = 1933
    
    On PR branch: 
    coveragePercent = 93.38
    linesCovered = 1467
    linesMissed = 104
    linesTotal = 1571
    
  • strftime-ruby: coverage remains 100%, lines from mock.in.rs removed.
    On trunk: 
    coveragePercent = 100.0
    linesCovered = 1908
    linesMissed = 0
    linesTotal = 1908
    
    On PR branch: 
    coveragePercent = 100.0
    linesCovered = 1903
    linesMissed = 0
    linesTotal = 1903
    

@lopopolo
Copy link
Member

Tweaked the --keep-only to use a src/**/*.rs glob to protect against grcov maybe reconfiguring the glob matcher to have * not match /. Changes are deployed, PRs are merged.

Thanks @x-hgg-x! 🚀

@lopopolo lopopolo merged commit dd00bf8 into artichoke:trunk Aug 22, 2022
@lopopolo lopopolo added A-aws Area: AWS infrastructure as code. A-github-actions Area: GitHub Actions workflows and automation. and removed A-aws Area: AWS infrastructure as code. labels Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-github-actions Area: GitHub Actions workflows and automation.
Development

Successfully merging this pull request may close these issues.

Coverage summary in CI reports numbers including dependencies exercised in tests
2 participants