Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add https:// if iss doesn't include it in JWT #24

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Add https:// if iss doesn't include it in JWT #24

merged 4 commits into from
Jan 21, 2021

Conversation

PurrBiscuit
Copy link
Contributor

Some issuers, like Google, don't include the protocol as part of their iss claim in their JWT's payload. This causes authentic to fail to retrieve the .well-known endpoint for Google JWTs. Adding a check to authentic that will look for http:// or https:// to be present in the iss claim and if it's not, it will add it to the .well-known url prior to looking for the jwks_uri.

Image 2021-01-20 at 5 06 50 PM

@PurrBiscuit PurrBiscuit requested review from a team and removed request for mgreystone January 21, 2021 18:08
tylerodonnell
tylerodonnell approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@tylerodonnell tylerodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, and looks good!

@PurrBiscuit PurrBiscuit merged commit 97ac795 into master Jan 21, 2021
@PurrBiscuit PurrBiscuit deleted the iss-url-https branch January 21, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerodonnell tylerodonnell tylerodonnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PurrBiscuit @tylerodonnell