[DDL] Cleaning up primary key creation #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
commented
Nov 8, 2024
| @@ -112,3 +116,114 @@ func (d *DDLTestSuite) TestCreateTemporaryTable() { | |||
| assert.Contains(d.T(), bqQuery, "CREATE TABLE IF NOT EXISTS `db`.`schema`.`tempTableName` (`foo` string,`bar` float64,`select` string) OPTIONS (expiration_timestamp =") | |||
| } | |||
| } | |||
|
|
|||
| func (d *DDLTestSuite) Test_DropTemporaryTableCaseSensitive() { | |||
There was a problem hiding this comment.
No changes to these tests. I just moved them from ddl_test.go
Tang8330
commented
Nov 8, 2024
| @@ -1,123 +1,40 @@ | |||
| package ddl_test | |||
| package ddl | |||
There was a problem hiding this comment.
Note the pkg name change. I moved all the other tests out so that we can have this be ddl. That way, we can have shouldCreatePrimaryKey remain a private function.
Once this PR merges, I'm going to try to remove the need for us to specify a different package name.
danafallon
reviewed
Nov 8, 2024
lib/typing/columns/columns.go
Outdated
| @@ -73,6 +72,11 @@ func (c *Column) ToLowerName() { | |||
| c.name = strings.ToLower(c.name) | |||
| } | |||
|
|
|||
| // SetPrimaryKey is used for tests only. | |||
| func (c *Column) SetPrimaryKey(primaryKey bool) { | |||
There was a problem hiding this comment.
Maybe we could name this SetPrimaryKeyForTest so it's extra clear that we shouldn't use it outside of tests?
danafallon
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standing up a function for determining whether we should be creating primary keys or not.