[DDL] More refactor around AlterTableArgs
#1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
changed the title
shared.CreateTable vs using AlterTableArgs
Tang8330
commented
Nov 14, 2024
| @@ -25,6 +25,6 @@ func CreateTable(ctx context.Context, dwh destination.DataWarehouse, tableData * | |||
| } | |||
|
|
|||
| // Update cache with the new columns that we've added. | |||
| tc.MutateInMemoryColumns(true, constants.Add, tableData.ReadOnlyInMemoryCols().GetColumns()...) | |||
| tc.MutateInMemoryColumns(false, constants.Add, tableData.ReadOnlyInMemoryCols().GetColumns()...) | |||
There was a problem hiding this comment.
This should have been false to begin with. I'm going to put up another PR to remove this flag.
Tang8330
changed the title
shared.CreateTable vs using AlterTableArgsAlterTableArgs
Closed
Tang8330
commented
Nov 14, 2024
| @@ -75,7 +75,6 @@ type AlterTableArgs struct { | |||
| // ContainsOtherOperations - this is sourced from tableData `containOtherOperations` | |||
| ContainOtherOperations bool | |||
| TableID sql.TableIdentifier | |||
| CreateTable bool | |||
There was a problem hiding this comment.
I removed the ability to create table in this function
danafallon
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shared.CreateTableAlterTableArgs