Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDL] Create table pass in columns #1062

Merged
merged 4 commits into from
Nov 20, 2024
Merged

[DDL] Create table pass in columns #1062

merged 4 commits into from
Nov 20, 2024

Conversation

Tang8330
Copy link
Contributor

We need to pass in an explicit set of columns to create a table with, rather than deriving it from tableData

This is because in Append and Merge, we are filtering out columns that we are using as metadata:

transfer/clients/shared/merge.go

Line 46 in fa08f22

err = createAlterTableArgs.AlterTable(dwh, targetKeysMissing...)

@Tang8330 Tang8330 marked this pull request as ready for review November 20, 2024 19:41
@Tang8330 Tang8330 requested a review from a team as a code owner November 20, 2024 19:41
@Tang8330 Tang8330 merged commit 637c81f into master Nov 20, 2024
3 checks passed
@Tang8330 Tang8330 deleted the adding-cols branch November 20, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-artie nathan-artie nathan-artie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tang8330 @nathan-artie