Improve Parquet #1064
Merged
Improve Parquet #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
commented
Nov 21, 2024
| @@ -49,8 +49,7 @@ func (s *Store) IdentifierFor(topicConfig kafkalib.TopicConfig, table string) sq | |||
| func (s *Store) ObjectPrefix(tableData *optimization.TableData) string { | |||
| tableID := s.IdentifierFor(tableData.TopicConfig(), tableData.Name()) | |||
| fqTableName := tableID.FullyQualifiedName() | |||
| yyyyMMDDFormat := tableData.LatestCDCTs.Format(ext.PostgresDateFormat) | |||
|
|
|||
| yyyyMMDDFormat := fmt.Sprintf("date=%s", time.Now().Format(ext.PostgresDateFormat)) | |||
There was a problem hiding this comment.
- This should be the current day, not when the CDC event was generated.
- Adding
date=so that it's consistent with Hive's partitioning scheme: https://lakefs.io/blog/hive-metastore-it-didnt-age-well/#hives-partitioning-scheme
Tang8330
commented
Nov 21, 2024
| @@ -89,29 +88,24 @@ func (s *Store) Merge(ctx context.Context, tableData *optimization.TableData) er | |||
| return fmt.Errorf("failed to create a local parquet file: %w", err) | |||
| } | |||
|
|
|||
| pw, err := writer.NewJSONWriter(schema, fw, 4) | |||
| pw, err := writer.NewCSVWriter(schema, fw, 4) | |||
There was a problem hiding this comment.
Using CSV instead since JSON schema for Parquet is not widely supported
Tang8330
commented
Nov 21, 2024
| "github.com/artie-labs/transfer/lib/typing/decimal" | ||
| "github.com/artie-labs/transfer/lib/typing/ext" | ||
| ) | ||
|
|
||
| func ParseValue(colVal any, colKind columns.Column) (any, error) { | ||
| func ParseValue(colVal any, colKind typing.KindDetails) (any, error) { |
There was a problem hiding this comment.
Using colKind instead, we don't need the whole column
nathan-artie
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving the way we write Parquet files, I've added comments to all the changes directly.